[Konversation-devel] Review Request: Make "Show/Hide Konversation" action always activate the window

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104116/#review11044
-----------------------------------------------------------

Ship it!


Makes sense to me, please commit and thank you.

- Eike Hein


On Feb. 29, 2012, 4:52 a.m., Parker Coates wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104116/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2012, 4:52 a.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Description
> -------
> 
> Konversation provides an action called "Show/Hide Konversation", which mostly useful for assigning a global shortcut to quickly access and dismiss the Konversation window.
> 
> This action is currently implemented such that if the window is not hidden, not minimised and on the current desktop, the window is hidden, otherwise the window is shown (and moved to the current desktop if necessary). This behaviour can be frustrating if the window is not hidden, not minimised, on the current desktop, and covered by other windows. Since the window can't be seen, one expects the action to show the window, but instead it hides it completely.
> 
> With this change, the action ignores whether or not the window is on the current desktop, but instead checks if Konversation is the active window. This simplifies the behaviour to: If Konversation is the active window, hide it. Otherwise, show it, move it to the current desktop, and activate it.
> 
> This is also consistent with the behaviour of the equivalent action in Amarok.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.cpp 112dd39 
> 
> Diff: http://git.reviewboard.kde.org/r/104116/diff/
> 
> 
> Testing
> -------
> 
> Tested against master. Saw no ill effects.
> 
> It could be that the old code that checked if the window was on the current desktop was handling some scenario I'm not understanding.
> 
> 
> Thanks,
> 
> Parker Coates
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20120301/3e7e05b2/attachment.html>