<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104116/">http://git.reviewboard.kde.org/r/104116/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Makes sense to me, please commit and thank you.</pre>
<br />
<p>- Eike</p>
<br />
<p>On February 29th, 2012, 4:52 a.m., Parker Coates wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konversation.</div>
<div>By Parker Coates.</div>
<p style="color: grey;"><i>Updated Feb. 29, 2012, 4:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Konversation provides an action called "Show/Hide Konversation", which mostly useful for assigning a global shortcut to quickly access and dismiss the Konversation window.
This action is currently implemented such that if the window is not hidden, not minimised and on the current desktop, the window is hidden, otherwise the window is shown (and moved to the current desktop if necessary). This behaviour can be frustrating if the window is not hidden, not minimised, on the current desktop, and covered by other windows. Since the window can't be seen, one expects the action to show the window, but instead it hides it completely.
With this change, the action ignores whether or not the window is on the current desktop, but instead checks if Konversation is the active window. This simplifies the behaviour to: If Konversation is the active window, hide it. Otherwise, show it, move it to the current desktop, and activate it.
This is also consistent with the behaviour of the equivalent action in Amarok.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested against master. Saw no ill effects.
It could be that the old code that checked if the window was on the current desktop was handling some scenario I'm not understanding.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mainwindow.cpp <span style="color: grey">(112dd39)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104116/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>