[Konversation-devel] Review Request: Port Q3MimeSourceFactory usage to QResource

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104539/#review12315
-----------------------------------------------------------

Ship it!


Ship It!

- Eike Hein


On April 10, 2012, 6:43 p.m., Martin Blumenstingl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104539/
> -----------------------------------------------------------
> 
> (Updated April 10, 2012, 6:43 p.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Description
> -------
> 
> Qt3Support--
> This simply uses QResource instead of Q3MimeSourceFactory.
> 
> Idea borrowed from here: https://svn.kvirc.de/kvirc/changeset/1976/trunk (random google hit)
> 
> After this, one only needs to port ViewTree/ViewTreeItem from Qt3Support to Qt4/Qt5.
> Then konversation is Qt3Support-free :)
> (There are some places where Q3* are used, but those are commented)
> 
> 
> Diffs
> -----
> 
>   src/irc/nickinfo.cpp e768d0d 
> 
> Diff: http://git.reviewboard.kde.org/r/104539/diff/
> 
> 
> Testing
> -------
> 
> No testing done as I don't use KABC.
> Could someone else test this please?
> 
> 
> Thanks,
> 
> Martin Blumenstingl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20120411/d8f69748/attachment.html>