[Konversation-devel] Review Request: Port Q3MimeSourceFactory usage to QResource
Martin Blumenstingl
martin.blumenstingl at googlemail.com
Tue Apr 10 18:43:32 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104539/
-----------------------------------------------------------
Review request for Konversation.
Description
-------
Qt3Support--
This simply uses QResource instead of Q3MimeSourceFactory.
Idea borrowed from here: https://svn.kvirc.de/kvirc/changeset/1976/trunk (random google hit)
After this, one only needs to port ViewTree/ViewTreeItem from Qt3Support to Qt4/Qt5.
Then konversation is Qt3Support-free :)
(There are some places where Q3* are used, but those are commented)
Diffs
-----
src/irc/nickinfo.cpp e768d0d
Diff: http://git.reviewboard.kde.org/r/104539/diff/
Testing
-------
No testing done as I don't use KABC.
Could someone else test this please?
Thanks,
Martin Blumenstingl
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20120410/fc777044/attachment.html>
More information about the Konversation-devel
mailing list