[Konversation-devel] Re: Review Request: Add support for the message indicator to Konversation

[Mark Kretschmann]

> On Nov. 18, 2010, 4:08 p.m., Eike Hein wrote:
> > KNotify is getting support for plugins in KDE 4.6, with config UI support for plugins scheduled for KDE 4.7. Wouldn't it make more sense to turn Message Indicator support into a KNotify plugin at that point, so apps don't need to be patched up individually nor duplicate the config UI?
> 
> Aurélien Gâteau wrote:
>     KNotify has always supported "plugins". They were statically linked in the knotify binary though. Are they becoming dynamic with 4.6?
>     
>     Anyway, I initially tried to implement message-indicator support as a new type of KNotify notification because I wanted to avoid patching applications, but it just doesn't fit. The m-i system lets the application provide a "server" which represents the application and multiple "indicators" which represent the incoming messages:
>     - The server is defined by a desktop file and can be triggered. The convention is to bring the application window to the front.
>     - An indicator consists of an icon, a text, an optional count and a flag to indicate whether it wants the user to pay attention to it. It can also be triggered, the convention in this case is to bring the application window to the front, and switch to the item represented by the indicator (In the case of Konversation, switch to the channel represented by the indicator)
>     
>     I don't think this can be represented in KNotify.

I agree with Aurélien.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100157/#review358
-----------------------------------------------------------


On Nov. 18, 2010, 3:27 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100157/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2010, 3:27 p.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Summary
> -------
> 
> The message indicator (m-i) is a new way for applications to indicate incoming messages to their users. It has been developed by Canonical and is available for GNOME and KDE. To build m-i support you need libindicate-qt https://launchpad.net/libindicate-qt . For Konversation to show the messages, you need a m-i applet. There is a KDE Plasma widget which does this, available from https://launchpad.net/plasma-widget-message-indicator .
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 83c9f1d 
>   config-konversation.h.cmake c3fb529 
>   src/CMakeLists.txt b063ee9 
>   src/config/konversation.kcfg c2b3d23 
>   src/config/messageindicator_config.ui PRE-CREATION 
>   src/config/settingsdialog.cpp 169e7ed 
>   src/notificationhandler.h 520d1ee 
>   src/notificationhandler.cpp f9a68de 
> 
> Diff: http://git.reviewboard.kde.org/r/100157/diff
> 
> 
> Testing
> -------
> 
> Kubuntu ships Konversation with this patch since a few releases now. I have been using it for a long time without problem.
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/konversation-devel/attachments/20110724/97d4e998/attachment.htm