[Konversation-devel] Re: Review Request: do not redraw the nicklist on a new message/action if sort by actifity is not enabled

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100303/#review742
-----------------------------------------------------------

Ship it!


Looks OK, please commit.

- Eike


On 2011-01-04 21:59:29, Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100303/
> -----------------------------------------------------------
> 
> (Updated 2011-01-04 21:59:29)
> 
> 
> Review request for Konversation.
> 
> 
> Summary
> -------
> 
> This Patch reduces they redraw of the nicklist on a new message/action in the channel if sort by actifity is not enabled
> 
> NOTE: this issue was found by using the kde compiz redraw highlighting thing
> 
> For every known nick that writes a message/action to the channel Channel::nickActive is called.
> (the new activity timestamp is set before the call)
> 
> Nick is QTreeWidgetItem, so the direct item of our NickListView.
> Nick::repositionMe() causes emitDataChanged and a nicklist resort, if nicklist sorting is enabled.
> (which also includes sort by user status)
> Now I only call Nick::repositionMe() if sort by actifity is enabled.
> So the nicklist won't be redrawn on a new message if sort by actifity is disabled.
> 
> Nick::repositionMe() is only called from Channel::nickActive, but there could be other future uses for this function,
> which is why I do not want to put the is sort by activity enabled check inside Nick::repositionMe()
> 
> I could not find any resulting problem from this, but I am also not sure if this is the right fix.
> NOTE: new timestamp is set and activity is increased
> 
> 
> Diffs
> -----
> 
>   src/irc/channel.cpp ed9ac67 
> 
> Diff: http://git.reviewboard.kde.org/r/100303/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/konversation-devel/attachments/20110105/e7b0a358/attachment.htm