<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100303/">http://git.reviewboard.kde.org/r/100303/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks OK, please commit.</pre>
<br />
<p>- Eike</p>
<br />
<p>On January 4th, 2011, 9:59 p.m., Bernd Buschinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konversation.</div>
<div>By Bernd Buschinski.</div>
<p style="color: grey;"><i>Updated 2011-01-04 21:59:29</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This Patch reduces they redraw of the nicklist on a new message/action in the channel if sort by actifity is not enabled
NOTE: this issue was found by using the kde compiz redraw highlighting thing
For every known nick that writes a message/action to the channel Channel::nickActive is called.
(the new activity timestamp is set before the call)
Nick is QTreeWidgetItem, so the direct item of our NickListView.
Nick::repositionMe() causes emitDataChanged and a nicklist resort, if nicklist sorting is enabled.
(which also includes sort by user status)
Now I only call Nick::repositionMe() if sort by actifity is enabled.
So the nicklist won't be redrawn on a new message if sort by actifity is disabled.
Nick::repositionMe() is only called from Channel::nickActive, but there could be other future uses for this function,
which is why I do not want to put the is sort by activity enabled check inside Nick::repositionMe()
I could not find any resulting problem from this, but I am also not sure if this is the right fix.
NOTE: new timestamp is set and activity is increased</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/irc/channel.cpp <span style="color: grey">(ed9ac67)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100303/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>