[Konversation-devel] Review Request: port tray icon to knotificationitem

[darklight.xdarklight at googlemail.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1965/
-----------------------------------------------------------

(Updated 2009-10-24 18:38:49.268878)


Review request for konversation.


Changes
-------

update description


Summary (updated)
-------

this ports the tray icon to knotificationitem

if knotificationitem is not available (on build time) the old implementation (using KSystemTray) will automatically be used as fallback
-> this means konversation will still compile on every system

note: Sho and I had problems when applying the patch to our svn trees
it seems that this was some bug in 'patch' (the application ;))
make sure that after applying the patch the content of trayiconknotificationitem.cpp and trayiconksystemtray.cpp is not multiple times in them.

all items from word's list are done - except #4 (which should be a seperate patch):
http://pastebin.ca/1613175


Diffs
-----

  trunk/extragear/network/konversation/CMakeLists.txt 1039836 
  trunk/extragear/network/konversation/config-konversation.h.cmake 1039836 
  trunk/extragear/network/konversation/src/CMakeLists.txt 1039836 
  trunk/extragear/network/konversation/src/mainwindow.cpp 1039836 
  trunk/extragear/network/konversation/src/viewer/trayicon.h 1039836 
  trunk/extragear/network/konversation/src/viewer/trayicon.cpp 1039836 
  trunk/extragear/network/konversation/src/viewer/trayiconknotificationitem.cpp PRE-CREATION 
  trunk/extragear/network/konversation/src/viewer/trayiconksystemtray.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/1965/diff


Testing
-------

I've been using this patch for some days now ;)


Thanks,

xdarklight