[Konversation-devel] Review Request: port tray icon to knotificationitem

darklight.xdarklight at googlemail.com darklight.xdarklight at googlemail.com
Sat Oct 24 20:33:41 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1965/
-----------------------------------------------------------

Review request for konversation.


Summary
-------

this ports the tray icon to knotificationitem

if knotificationitem is not available (on build time) the old implementation (using KSystemTray) will automatically be used as fallback
-> this means konversation will still compile on every system


Diffs
-----

  trunk/extragear/network/konversation/CMakeLists.txt 1039836 
  trunk/extragear/network/konversation/config-konversation.h.cmake 1039836 
  trunk/extragear/network/konversation/src/CMakeLists.txt 1039836 
  trunk/extragear/network/konversation/src/mainwindow.cpp 1039836 
  trunk/extragear/network/konversation/src/viewer/trayicon.h 1039836 
  trunk/extragear/network/konversation/src/viewer/trayicon.cpp 1039836 
  trunk/extragear/network/konversation/src/viewer/trayiconknotificationitem.cpp PRE-CREATION 
  trunk/extragear/network/konversation/src/viewer/trayiconksystemtray.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/1965/diff


Testing
-------

I've been using this patch for some days now ;)


Thanks,

xdarklight



More information about the Konversation-devel mailing list