[Konversation-devel] Review Request: port tray icon to knotificationitem

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1965/#review3412
-----------------------------------------------------------

Ship it!


Merged via http://gitorious.org/konversation/konversation/merge_requests/3

- Eike


On 2009-10-31 00:24:12, xdarklight wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1965/
> -----------------------------------------------------------
> 
> (Updated 2009-10-31 00:24:12)
> 
> 
> Review request for konversation.
> 
> 
> Summary
> -------
> 
> this ports the tray icon to knotificationitem
> 
> if knotificationitem is not available (on build time) the old implementation (using KSystemTray) will automatically be used as fallback
> -> this means konversation will still compile on every system
> 
> note: Sho and I had problems when applying the patch to our svn trees
> it seems that this was some bug in 'patch' (the application ;))
> make sure that after applying the patch the content of trayiconknotificationitem.cpp and trayiconksystemtray.cpp is not multiple times in them.
> 
> all items from word's list are done - except #4 (which should be a seperate patch):
> http://pastebin.ca/1613175
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/network/konversation/CMakeLists.txt 1042888 
>   trunk/extragear/network/konversation/cmake/modules/FindLibKNotificationItem-1.cmake PRE-CREATION 
>   trunk/extragear/network/konversation/config-konversation.h.cmake 1042888 
>   trunk/extragear/network/konversation/src/CMakeLists.txt 1042888 
>   trunk/extragear/network/konversation/src/mainwindow.cpp 1042888 
>   trunk/extragear/network/konversation/src/notificationhandler.cpp 1042888 
>   trunk/extragear/network/konversation/src/viewer/trayicon.h 1042888 
>   trunk/extragear/network/konversation/src/viewer/trayicon.cpp 1042888 
>   trunk/extragear/network/konversation/src/viewer/trayiconknotificationitem.cpp PRE-CREATION 
>   trunk/extragear/network/konversation/src/viewer/trayiconksystemtray.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1965/diff
> 
> 
> Testing
> -------
> 
> I've been using this patch for some days now ;)
> 
> 
> Thanks,
> 
> xdarklight
> 
>