[Konversation-devel] [Bug 132230] selected text is deselected on channel activity

[Eli MacKenzie]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=132230         




------- Additional Comments From argonel sympatico ca  2007-07-08 20:21 -------
SVN commit 685395 by argonel:

silence unnecessary qWarning emanating from the bowels of qtextedit

CCBUG:132230



 M  +1 -1      commit.h  
 M  +3 -4      ircview.cpp  


--- branches/extragear/kde3/network/konversation/src/commit.h #685394:685395
 @ -1,4 +1,4  @
 // This COMMIT number is added to version string to be used as "patch level"
 #ifndef COMMIT
-#define COMMIT 3209
+#define COMMIT 3210
 #endif
--- branches/extragear/kde3/network/konversation/src/ircview.cpp #685394:685395
 @ -981,9 +981,10  @
     // at an end, so the scrollbar wets its pants and forgets who it is for ten minutes
     if (doScroll)
     {
-        int sbm = Preferences::scrollbackMax();
+        int sbm = Preferences::scrollbackMax(); //note: reused below
+        int numRemoved = paragraphs() - sbm;
 
-        if(sbm)
+        if(numRemoved >0)
         {
             //Explanation: the scrolling mechanism cannot handle the buffer changing when the scrollbar is not
             // at an end, so the scrollbar wets its pants and forgets who it is for ten minutes
 @ -991,8 +992,6  @
             {
                 int paraFrom, indexFrom, paraTo, indexTo;
                 getSelection(&paraFrom, &indexFrom, &paraTo, &indexTo); // Remember the selection so we don't loose it when removing lines
-                int numRemoved = paragraphs() - sbm;
-
                 for (sbm = numRemoved; sbm > 0; --sbm)
                 {
                     removeParagraph(0);