Fwd: New Defects reported by Coverity Scan for Konsole

[Kurt Hindenburg]

1. sa_pound seems like a false positive as resetCharset sets it.

2.  I don't know what to return upon an error; I sent an email to 
mglb at arccos-1.net a few months ago asking for help.

3. Fixed

On 5/15/20 3:07 PM, Kurt Hindenburg wrote:
>
> This is from master a few minutes ago.  I haven't looked at any of 
> these yet.
>
>
> Kurt
>
>
>
> -------- Forwarded Message --------
> Subject: 	New Defects reported by Coverity Scan for Konsole
> Date: 	Fri, 15 May 2020 19:03:59 +0000 (UTC)
> From: 	scan-admin at coverity.com
> To: 	kurt.hindenburg at gmail.com
>
>
>
> Hi,
>
> Please find the latest report on new defect(s) introduced to Konsole 
> found with Coverity Scan.
>
> 3 new defect(s) introduced to Konsole found with Coverity Scan.
> 2 defect(s), reported by Coverity Scan earlier, were marked fixed in 
> the recent build analyzed by Coverity Scan.
>
> New defect(s) Reported-by: Coverity Scan
> Showing 3 of 3 defect(s)
>
>
> ** CID 302767: Uninitialized members (UNINIT_CTOR)
> /home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 80 
> in Konsole::Vt102Emulation::Vt102Emulation()()
>
>
> ________________________________________________________________________________________________________
> *** CID 302767: Uninitialized members (UNINIT_CTOR)
> /home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 80 
> in Konsole::Vt102Emulation::Vt102Emulation()()
> 74 {
> 75 _sessionAttributesUpdateTimer->setSingleShot(true);
> 76 QObject::connect(_sessionAttributesUpdateTimer, &QTimer::timeout, this,
> 77 &Konsole::Vt102Emulation::updateSessionAttributes);
> 78 79 initTokenizer();
>>>> CID 302767: Uninitialized members (UNINIT_CTOR)
>>>> Non-static class member field "_charset.sa_pound" is not 
>>>> initialized in this constructor nor in any functions that it calls.
> 80 }
> 81 82 Vt102Emulation::~Vt102Emulation() = default;
> 83 84 void Vt102Emulation::clearEntireScreen()
> 85 {
>
> ** CID 302766: Null pointer dereferences (NULL_RETURNS)
> /home/kurthindenburg/Devel/KDE/src/konsole/src/TerminalDisplay.cpp: 
> 1535 in baseCodePoint(const Konsole::Character &)()
>
>
> ________________________________________________________________________________________________________
> *** CID 302766: Null pointer dereferences (NULL_RETURNS)
> /home/kurthindenburg/Devel/KDE/src/konsole/src/TerminalDisplay.cpp: 
> 1535 in baseCodePoint(const Konsole::Character &)()
> 1529 1530 static uint baseCodePoint(const Character &ch) {
> 1531 if (ch.rendition & RE_EXTENDED_CHAR) {
> 1532 // sequence of characters
> 1533 ushort extendedCharLength = 0;
> 1534 const uint* chars = 
> ExtendedCharTable::instance.lookupExtendedChar(ch.character, 
> extendedCharLength);
>>>> CID 302766: Null pointer dereferences (NULL_RETURNS)
>>>> Dereferencing "chars", which is known to be "nullptr".
> 1535 return chars[0];
> 1536 } else {
> 1537 return ch.character;
> 1538 }
> 1539 }
> 1540
> ** CID 302765: Null pointer dereferences (FORWARD_NULL)
>
>
> ________________________________________________________________________________________________________
> *** CID 302765: Null pointer dereferences (FORWARD_NULL)
> /home/kurthindenburg/Devel/KDE/src/konsole/src/TerminalHeaderBar.cpp: 
> 181 in 
> Konsole::TerminalHeaderBar::updateSpecialState(Konsole::ViewProperties 
> *)()
> 175 }
> 176 177 void TerminalHeaderBar::updateSpecialState(ViewProperties *item)
> 178 {
> 179 auto controller = dynamic_cast<SessionController*>(item);
> 180
>>>> CID 302765: Null pointer dereferences (FORWARD_NULL)
>>>> Passing null pointer "controller" to "isReadOnly", which 
>>>> dereferences it.
> 181 m_statusIconReadOnly->setVisible(controller->isReadOnly());
> 182 m_statusIconCopyInput->setVisible(controller->isCopyInputActive());
> 183 }
> 184 185 void TerminalHeaderBar::paintEvent(QPaintEvent *paintEvent)
> 186 {
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20200704/db4b6da9/attachment.htm>