<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>1. sa_pound seems like a false positive as resetCharset sets it.</p>
<p>2. I don't know what to return upon an error; I sent an email to
<a class="moz-txt-link-abbreviated" href="mailto:mglb@arccos-1.net">mglb@arccos-1.net</a> a few months ago asking for help.<br>
</p>
<p>3. Fixed<br>
</p>
<div class="moz-cite-prefix">On 5/15/20 3:07 PM, Kurt Hindenburg
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:cbb78cd6-957f-40dd-7aa6-c06738f1c6b3@gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<p>This is from master a few minutes ago. I haven't looked at any
of these yet.</p>
<p><br>
</p>
<p>Kurt<br>
</p>
<div class="moz-forward-container"><br>
<br>
-------- Forwarded Message --------
<table class="moz-email-headers-table" cellspacing="0"
cellpadding="0" border="0">
<tbody>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">Subject:
</th>
<td>New Defects reported by Coverity Scan for Konsole</td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">Date:
</th>
<td>Fri, 15 May 2020 19:03:59 +0000 (UTC)</td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">From:
</th>
<td><a class="moz-txt-link-abbreviated"
href="mailto:scan-admin@coverity.com"
moz-do-not-send="true">scan-admin@coverity.com</a></td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">To: </th>
<td><a class="moz-txt-link-abbreviated"
href="mailto:kurt.hindenburg@gmail.com"
moz-do-not-send="true">kurt.hindenburg@gmail.com</a></td>
</tr>
</tbody>
</table>
<br>
<br>
Hi,<br>
<br>
Please find the latest report on new defect(s) introduced to
Konsole found with Coverity Scan.<br>
<br>
3 new defect(s) introduced to Konsole found with Coverity Scan.<br>
2 defect(s), reported by Coverity Scan earlier, were marked
fixed in the recent build analyzed by Coverity Scan.<br>
<br>
New defect(s) Reported-by: Coverity Scan<br>
Showing 3 of 3 defect(s)<br>
<br>
<br>
** CID 302767: Uninitialized members (UNINIT_CTOR)<br>
/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 80 in
Konsole::Vt102Emulation::Vt102Emulation()()<br>
<br>
<br>
________________________________________________________________________________________________________<br>
*** CID 302767: Uninitialized members (UNINIT_CTOR)<br>
/home/kurthindenburg/Devel/KDE/src/konsole/src/Vt102Emulation.cpp: 80 in
Konsole::Vt102Emulation::Vt102Emulation()()<br>
74 {<br>
75 _sessionAttributesUpdateTimer->setSingleShot(true);<br>
76 QObject::connect(_sessionAttributesUpdateTimer,
&QTimer::timeout, this,<br>
77 &Konsole::Vt102Emulation::updateSessionAttributes);<br>
78 79 initTokenizer();<br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite"> CID 302767: Uninitialized members
(UNINIT_CTOR)<br>
Non-static class member field "_charset.sa_pound" is not
initialized in this constructor nor in any functions that
it calls.<br>
</blockquote>
</blockquote>
</blockquote>
80 }<br>
81 82 Vt102Emulation::~Vt102Emulation() = default;<br>
83 84 void Vt102Emulation::clearEntireScreen()<br>
85 {<br>
<br>
** CID 302766: Null pointer dereferences (NULL_RETURNS)<br>
/home/kurthindenburg/Devel/KDE/src/konsole/src/TerminalDisplay.cpp: 1535
in baseCodePoint(const Konsole::Character &)()<br>
<br>
<br>
________________________________________________________________________________________________________<br>
*** CID 302766: Null pointer dereferences (NULL_RETURNS)<br>
/home/kurthindenburg/Devel/KDE/src/konsole/src/TerminalDisplay.cpp: 1535
in baseCodePoint(const Konsole::Character &)()<br>
1529 1530 static uint baseCodePoint(const Character &ch) {<br>
1531 if (ch.rendition & RE_EXTENDED_CHAR) {<br>
1532 // sequence of characters<br>
1533 ushort extendedCharLength = 0;<br>
1534 const uint* chars =
ExtendedCharTable::instance.lookupExtendedChar(ch.character,
extendedCharLength);<br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite"> CID 302766: Null pointer
dereferences (NULL_RETURNS)<br>
Dereferencing "chars", which is known to be "nullptr".<br>
</blockquote>
</blockquote>
</blockquote>
1535 return chars[0];<br>
1536 } else {<br>
1537 return ch.character;<br>
1538 }<br>
1539 }<br>
1540 <br>
** CID 302765: Null pointer dereferences (FORWARD_NULL)<br>
<br>
<br>
________________________________________________________________________________________________________<br>
*** CID 302765: Null pointer dereferences (FORWARD_NULL)<br>
/home/kurthindenburg/Devel/KDE/src/konsole/src/TerminalHeaderBar.cpp:
181 in
Konsole::TerminalHeaderBar::updateSpecialState(Konsole::ViewProperties
*)()<br>
175 }<br>
176 177 void
TerminalHeaderBar::updateSpecialState(ViewProperties *item)<br>
178 {<br>
179 auto controller =
dynamic_cast<SessionController*>(item);<br>
180
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite"> CID 302765: Null pointer
dereferences (FORWARD_NULL)<br>
Passing null pointer "controller" to "isReadOnly", which
dereferences it.<br>
</blockquote>
</blockquote>
</blockquote>
181
m_statusIconReadOnly->setVisible(controller->isReadOnly());<br>
182
m_statusIconCopyInput->setVisible(controller->isCopyInputActive());<br>
183 }<br>
184 185 void TerminalHeaderBar::paintEvent(QPaintEvent
*paintEvent)<br>
186 {<br>
<br>
<br>
<br>
<br>
</div>
</blockquote>
</body>
</html>