Fwd: [konsole] src: Fix context menu actions when search bar is enabled

[kurt.hindenburg at gmail.com]

FYI - I would not blindly follow this; just something to look at.


  Check for classes that should use the 'Q_OBJECT' macro [qobject]... 1 issue found
	./src/Filter.h: line#76 (1)
	QObject derived classes should use the Q_OBJECT macro.




-------- Forwarded Message --------
Subject: 	[konsole] src: Fix context menu actions when search bar is 
enabled
Date: 	Thu, 30 Jan 2020 01:09:08 +0000 (UTC)
From: 	Kurt Hindenburg <null at kde.org>
Reply-To: 	kde-commits at kde.org, Kurt Hindenburg <kurt.hindenburg at gmail.com>
To: 	kde-commits at kde.org



Git commit 96cda154c16e41c9ec29b3a8716f8b83c7860087 by Kurt Hindenburg, 
on behalf of Tomaz Canabrava.
Committed on 30/01/2020 at 01:08.
Pushed by hindenburg into branch 'master'.

Fix context menu actions when search bar is enabled

The actions are destroyed during a focusIn / focusOut, and recreated
with the same content but different memory positions, and that
killed the QActions inside of the menu.

To trigger this is simple, open the search bar, type some url in
konsole, and right click on it: you will not see the actions
to copy and go to url.

moving the related code to QSharedPointer fixes this by delaying
the destruction of the pointer untill the menu is closed.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20200210/a3f09d3d/attachment.html>