<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
<p>FYI - I would not blindly follow this; just something to look at.<br>
</p>
<p><br>
</p>
<pre class="moz-quote-pre" wrap=""> Check for classes that should use the 'Q_OBJECT' macro [qobject]... 1 issue found
./src/Filter.h: line#76 (1)
QObject derived classes should use the Q_OBJECT macro.</pre>
<br>
<div class="moz-forward-container"><br>
<br>
-------- Forwarded Message --------
<table class="moz-email-headers-table" cellspacing="0"
cellpadding="0" border="0">
<tbody>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">Subject:
</th>
<td>[konsole] src: Fix context menu actions when search bar
is enabled</td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">Date: </th>
<td>Thu, 30 Jan 2020 01:09:08 +0000 (UTC)</td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">From: </th>
<td>Kurt Hindenburg <a class="moz-txt-link-rfc2396E" href="mailto:null@kde.org"><null@kde.org></a></td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">Reply-To:
</th>
<td><a class="moz-txt-link-abbreviated" href="mailto:kde-commits@kde.org">kde-commits@kde.org</a>, Kurt Hindenburg
<a class="moz-txt-link-rfc2396E" href="mailto:kurt.hindenburg@gmail.com"><kurt.hindenburg@gmail.com></a></td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">To: </th>
<td><a class="moz-txt-link-abbreviated" href="mailto:kde-commits@kde.org">kde-commits@kde.org</a></td>
</tr>
</tbody>
</table>
<br>
<br>
Git commit 96cda154c16e41c9ec29b3a8716f8b83c7860087 by Kurt
Hindenburg, on behalf of Tomaz Canabrava.<br>
Committed on 30/01/2020 at 01:08.<br>
Pushed by hindenburg into branch 'master'.<br>
<br>
Fix context menu actions when search bar is enabled<br>
<br>
The actions are destroyed during a focusIn / focusOut, and
recreated<br>
with the same content but different memory positions, and that<br>
killed the QActions inside of the menu.<br>
<br>
To trigger this is simple, open the search bar, type some url in<br>
konsole, and right click on it: you will not see the actions<br>
to copy and go to url.<br>
<br>
moving the related code to QSharedPointer fixes this by delaying<br>
the destruction of the pointer untill the menu is closed.<br>
<br>
<br>
</div>
</body>
</html>