D21301: Add a TerminalHeader when using splits

Tomaz Canabrava tcanabrava at kde.org
Tue May 21 20:33:07 BST 2019

I'll do what the VDG decides.
but this is fixing an actuall issue so maybe it's worth to accept and then
fine tune later?

On Tue, May 21, 2019 at 8:45 PM Noah Davis <noreply at phabricator.kde.org>

> ndavis added a comment. View Revision <https://phabricator.kde.org/D21301>
> In D21301#467973 <https://phabricator.kde.org/D21301#467973>, @ngraham
> <https://phabricator.kde.org/p/ngraham/> wrote:
> Fantastic. The dark inactive tab is maybe a bit too dark, but that's a
> fairly minor thing.
> I agree, the header for the prompt on the right seems too dark because
> text has poor contrast.
> One remaining UI niggle I can see is that I'd like a horizontal line
> separating the headerbars from the menubar for the case where the tab bar
> is hidden. When the tab bar is shown, it provides its own line, which looks
> good: F6841233: Screenshot_20190521_094624.png
> <https://phabricator.kde.org/F6841233>
> But when the tab bar is hidden, there's no separation and it looks a bit
> weird: F6841236: Screenshot_20190521_094723.png
> <https://phabricator.kde.org/F6841236>
> Or maybe this isn't a big deal? What do you think? #VDG
> <https://phabricator.kde.org/tag/vdg/>?
> Without separation, it reminds me of old Safari:
> https://www.uberphones.com/wp-content/uploads/2011/06/ipad-safari-tabs-update.jpg
> I don't think it's a big deal, but it might be nice to have a separating
> line.
> Also, if the button with the view-fullscreen icon is a maximize button,
> wouldn't it be better to use window-maximize or window-restore?
> R319 Konsole
> https://phabricator.kde.org/D21301
> *To: *tcanabrava, Konsole, hindenburg, ngraham, VDG
> *Cc: *ndavis, shubham, konsole-devel, gennad, thsurrel, ngraham,
> maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190521/7e903cfa/attachment-0001.html>

More information about the konsole-devel mailing list