D20088: Use one liners where appropriate.
Tomaz Canabrava
noreply at phabricator.kde.org
Thu Mar 28 11:40:45 GMT 2019
tcanabrava updated this revision to Diff 54979.
tcanabrava added a comment.
- Use one liners where appropriate.
- Remove sender() and QVariant() conversions
- Declare + initialize, instead of setting the value later
- Don't create unecessary temporaries
- Extract code from huge function into a smaller one
REPOSITORY
R319 Konsole
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20088?vs=54976&id=54979
BRANCH
simplifyCode
REVISION DETAIL
https://phabricator.kde.org/D20088
AFFECTED FILES
src/TerminalDisplay.cpp
src/TerminalDisplay.h
To: tcanabrava
Cc: konsole-devel, gennad, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190328/7e8673a8/attachment.html>
More information about the konsole-devel
mailing list