D20089: Remove sender() and QVariant() conversions

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  instead of having an actual signal, we can use a lambda to get
  rid of the conversion to QVariant, check for sender(), check
  for QAction, convert back to QVariant, convert to QString,
  convert to QByteArray.
  
  Send the values as QString directly, convert only once.

REPOSITORY
  R319 Konsole

BRANCH
  preferNoConversions

REVISION DETAIL
  https://phabricator.kde.org/D20089

AFFECTED FILES
  src/TerminalDisplay.cpp
  src/TerminalDisplay.h

To: tcanabrava
Cc: konsole-devel, gennad, maciejn, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190328/713f48c2/attachment.html>