D18735: Improve built-in line/block characters drawing

Kurt Hindenburg noreply at phabricator.kde.org
Sun Mar 3 03:42:34 GMT 2019


hindenburg added inline comments.

INLINE COMMENTS

> LineBlockCharacters.cpp:258
> +    // Fully draws: ╋ ╂ ┃ ┿ ┼ │ ━ ─
> +    for (unsigned topIndex = 0; topIndex < LinesNum/2; topIndex++) {
> +        unsigned iB = (topIndex + 2) % LinesNum;

There's a krazy check that suggest this might be better using prefix due to efficient ( ie ++topIndex) - I haven't checked if this change would work here.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D18735

To: mglb, #konsole, #vdg, hindenburg
Cc: hindenburg, sandsmark, fvogt, konsole-devel, gennad, maciejn, thsurrel, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190303/ee08c73e/attachment.html>


More information about the konsole-devel mailing list