<table><tr><td style="">hindenburg added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18735">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18735#inline-108759">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LineBlockCharacters.cpp:258</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// Fully draws: ╋ ╂ ┃ ┿ ┼ │ ━ ─</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">unsigned</span> <span class="n">topIndex</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> <span class="n">topIndex</span> <span style="color: #aa2211"><</span> <span class="n">LinesNum</span><span style="color: #aa2211">/</span><span style="color: #601200">2</span><span class="p">;</span> <span class="n">topIndex</span><span style="color: #aa2211">++</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">unsigned</span> <span class="n">iB</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">topIndex</span> <span style="color: #aa2211">+</span> <span style="color: #601200">2</span><span class="p">)</span> <span style="color: #aa2211">%</span> <span class="n">LinesNum</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There's a krazy check that suggest this might be better using prefix due to efficient ( ie ++topIndex) - I haven't checked if this change would work here.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18735">https://phabricator.kde.org/D18735</a></div></div><br /><div><strong>To: </strong>mglb, Konsole, VDG, hindenburg<br /><strong>Cc: </strong>hindenburg, sandsmark, fvogt, konsole-devel, gennad, maciejn, thsurrel, ngraham, maximilianocuria<br /></div>