D20816: Configure Konsole dialog GUI redesign
Mariusz Glebocki
noreply at phabricator.kde.org
Sat Jun 15 11:41:39 BST 2019
mglb updated this revision to Diff 59866.
mglb retitled this revision from "[WIP] Configure Konsole dialog GUI redesign" to "Configure Konsole dialog GUI redesign".
mglb edited the summary of this revision.
mglb added a comment.
- Fix radio button name
- Add short info about profile shortcuts and visibility
- Add kuit tags
- Use modified QKeySequenceEdit for shortcut editing.
- Use disabled text color for non visible profile's shortcut text
This revision is ready for a review and can be commited. I didn't spot any bugs, but there are some things that could be improved in future:
- Shortcut editor should check for conflicts
- Cleanup
REPOSITORY
R319 Konsole
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20816?vs=58955&id=59866
BRANCH
wip/Configure-Konsole-dialog-GUI-redesing (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D20816
AFFECTED FILES
src/CMakeLists.txt
src/EditProfileGeneralPage.ui
src/MainWindow.cpp
src/settings/ConfigurationDialog.cpp
src/settings/ConfigurationDialog.h
src/settings/FileLocationSettings.cpp
src/settings/FileLocationSettings.h
src/settings/FileLocationSettings.ui
src/settings/GeneralSettings.ui
src/settings/ProfileSettings.cpp
src/settings/ProfileSettings.h
src/settings/ProfileSettings.ui
src/settings/TabBarSettings.cpp
src/settings/TabBarSettings.ui
src/settings/TemporaryFilesSettings.cpp
src/settings/TemporaryFilesSettings.h
src/settings/TemporaryFilesSettings.ui
To: mglb, #konsole, #vdg, ngraham
Cc: ngraham, hindenburg, #vdg, konsole-devel, #konsole, cblack, arvidhansson, ian, jguidon, hannahk, Ghost6, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, thsurrel, mglb, crozbo, ndavis, firef, skadinna, maximilianocuria, aaronhoneycutt, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190615/0a42872f/attachment.html>
More information about the konsole-devel
mailing list