<table><tr><td style="">mglb updated this revision to Diff 59866.<br />mglb retitled this revision from "[WIP] Configure Konsole dialog GUI redesign" to "Configure Konsole dialog GUI redesign".<br />mglb edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-fdteewudln5x2xp/">(Show Details)</a><br />mglb added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20816">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">Fix radio button name</li>
<li class="remarkup-list-item">Add short info about profile shortcuts and visibility</li>
<li class="remarkup-list-item">Add kuit tags</li>
<li class="remarkup-list-item">Use modified QKeySequenceEdit for shortcut editing.</li>
<li class="remarkup-list-item">Use disabled text color for non visible profile's shortcut text</li>
</ul>
<p>This revision is ready for a review and can be commited. I didn't spot any bugs, but there are some things that could be improved in future:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Shortcut editor should check for conflicts</li>
<li class="remarkup-list-item">Cleanup</li>
</ul></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">* Extensions/workarounds for KF5 classes - I'll fix the</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">* Use custom dialog and configuraton</span> classes<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> in KF5 later.</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">,</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">This allows to make it work for now.</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">as counterparts from KF5</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">* Create new KConfigDialog-like class and use it to</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">are bugged. The KF5 versions</span> sho<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">w existing configuration pages</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">uld be fixed and used here</span>.<br />
* Create <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">KConfigDialogManager-like class for managing QButtonGroups<br />
<br />
* Remove help button from configuration dialog. There is nothing about configuration dialog options in the help</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">new KConfigDialog-like class and use it to show existing<br />
configuration pages.<br />
* Create KConfigDialogManager-like class for managing QButtonGroups</span>.<br />
<br />
* Re<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">name "File Location" to "Temporary Files" - this page probably will be removed (D20466)</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">move help button from configuration dialog. There is nothing about</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">* Enable path selector only when "custom" is selected</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">configuration dialog options in the help.<br />
<br />
* Profile Settings:</span><br />
* <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">Place paths directly in labels<br />
<br />
* Disable all tabbar settings except visibility when visibility is set to "Never"<br />
<br />
* Profile Settings</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Use QTreeView instead of QTableView - it highlights whole lines,<br />
aligns header names to the left, etc. Basically it looks like lists<br />
in file manager or e.g. plugin list in Kate.</span><br />
* Use <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">QTreeView instead of QTableView - it highlights whole lines, aligns header names to the left, etc. Basically it looks like lists in file manager or e.g. plugin list in Kate</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">(default) QStyledItemDelegate with checkbox instead of custom<br />
delegate (tick mark) in favorite/show column</span>.<br />
* <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">Use (default) QStyledItemDelegate with checkbox instead of custom delegate (tick mark) in favorite/show column. I like this look, but there is a task to standardize list views, so it will probably be changed in future anyway (T10384)</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Change default profile item style - it now has italics font and<br />
"(default)" suffix.</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">* Change default profile item style - it now has italics font and "(default)" suffix.</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">* Disable "Delete" button when default profile is selected</span><br />
* <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">Disable "Delete" button when default profile is selected<br />
<br />
* Minor string changes<br />
<br />
**TODO**</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Use slightly extended QKeySequenceEditor. KKeySequenceWidget looks<br />
heavily out of place in a tree view. New editor supports some<br />
control keys:<br />
* Esc key cancels key capture.<br />
* Del/backspace removes shortcut.<br />
* Enter confirms shortcut immediately.</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">* Allow to remove profile</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> * Tab/backtab commits currently edited</span> shor<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">tcut</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">cut and moves to</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">* Gray-out shortcut text for non-favorite items (with appropriate tooltip) or restore the label on profiles page</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> next/previous shortcut.</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">* Fix s</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> * S</span>hortcut<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> delegate alignment/sizes. Increase column minimum width</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">s for non visible profiles use disabled text color.</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">* Cleanup</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> * Note about visibility and shortcuts</span><br />
<br />
*<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">*Screenshots**</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> Rename "File Location" to "Temporary Files"<br />
* Enable path selector only when "custom" is selected<br />
* Place paths directly in labels</span><br />
<br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">{F6792928}</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">* Disable all tabbar settings except visibility when visibility is set</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">{F6792929}</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> to "Never"<br />
<br />
* Minor string changes.<br />
<br />
**Screenshots**<br />
<br />
{F6893460}</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">{F6792930}</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">{F6893461}</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">{F6792931}</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">{F6893462}</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">{F6792932}</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">{F6893463}</span><br />
<br />
BUG: 404096<div style="padding: 8px 0;">...</div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D20816?vs=58955&id=59866">https://phabricator.kde.org/D20816?vs=58955&id=59866</a></div></div><br /><div><strong>BRANCH</strong><div><div>wip/Configure-Konsole-dialog-GUI-redesing (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20816">https://phabricator.kde.org/D20816</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/CMakeLists.txt<br />
src/EditProfileGeneralPage.ui<br />
src/MainWindow.cpp<br />
src/settings/ConfigurationDialog.cpp<br />
src/settings/ConfigurationDialog.h<br />
src/settings/FileLocationSettings.cpp<br />
src/settings/FileLocationSettings.h<br />
src/settings/FileLocationSettings.ui<br />
src/settings/GeneralSettings.ui<br />
src/settings/ProfileSettings.cpp<br />
src/settings/ProfileSettings.h<br />
src/settings/ProfileSettings.ui<br />
src/settings/TabBarSettings.cpp<br />
src/settings/TabBarSettings.ui<br />
src/settings/TemporaryFilesSettings.cpp<br />
src/settings/TemporaryFilesSettings.h<br />
src/settings/TemporaryFilesSettings.ui</div></div></div><br /><div><strong>To: </strong>mglb, Konsole, VDG, ngraham<br /><strong>Cc: </strong>ngraham, hindenburg, VDG, konsole-devel, Konsole, cblack, arvidhansson, ian, jguidon, hannahk, Ghost6, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, thsurrel, mglb, crozbo, ndavis, firef, skadinna, maximilianocuria, aaronhoneycutt, mbohlender<br /></div>