D18154: Add a "Session Switcher" via Ctrl + Tab

[Mariusz Glebocki]

mglb added a comment.


  In D18154#402430 <https://phabricator.kde.org/D18154#402430>, @hindenburg wrote:
  
  > 4. I'm tempted to have a way to turn off the popup.
  
  
  "last used view" (or "next/prev tab"?) does the same thing without popup. Or have I missed something?

INLINE COMMENTS

> lucasew wrote in ViewManager.cpp:295
> What you think about change the previous context hotkey to shift instead of meta. Some well known software like browsers use this shortcut and I think it will be more natural and intuitive.

I think Alt instead of Meta should be used - KDE applications do not usually use Meta for non-global things (AFAIR).
@lucasew: Shift works as reverse modifier in features like this, so I would expect it to show session switcher in backward mode.

> ViewManager.cpp:299
>  
>      collection->setDefaultShortcut(lastUsedViewReverseAction, Qt::CTRL + Qt::SHIFT + Qt::Key_Tab);
>      connect(lastUsedViewReverseAction, &QAction::triggered, this, &Konsole::ViewManager::lastUsedViewReverse);

Can you change this to be the shortcut from lastUsedViewAction + Shift?

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D18154

To: tcanabrava, hindenburg, #konsole
Cc: mglb, ngraham, thsurrel, lucasew, mart, konsole-devel, maciejn, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190130/fa5ddfc6/attachment.html>