<table><tr><td style="">mglb added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18154">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D18154#402430" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D18154#402430</a>, <a href="https://phabricator.kde.org/p/hindenburg/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@hindenburg</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><ol class="remarkup-list" start="4">
<li class="remarkup-list-item">I'm tempted to have a way to turn off the popup.</li>
</ol></div>
</blockquote>
<p>"last used view" (or "next/prev tab"?) does the same thing without popup. Or have I missed something?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18154#inline-100152">View Inline</a><span style="color: #4b4d51; font-weight: bold;">lucasew</span> wrote in <span style="color: #4b4d51; font-weight: bold;">ViewManager.cpp:295</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">What you think about change the previous context hotkey to shift instead of meta. Some well known software like browsers use this shortcut and I think it will be more natural and intuitive.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think Alt instead of Meta should be used - KDE applications do not usually use Meta for non-global things (AFAIR).<br />
<a href="https://phabricator.kde.org/p/lucasew/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@lucasew</a>: Shift works as reverse modifier in features like this, so I would expect it to show session switcher in backward mode.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18154#inline-103355">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ViewManager.cpp:299</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">collection</span><span style="color: #aa2211">-></span><span class="n">setDefaultShortcut</span><span class="p">(</span><span class="n">lastUsedViewReverseAction</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">CTRL</span> <span style="color: #aa2211">+</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">SHIFT</span> <span style="color: #aa2211">+</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">Key_Tab</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">connect</span><span class="p">(</span><span class="n">lastUsedViewReverseAction</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QAction</span><span style="color: #aa2211">::</span><span class="n">triggered</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">Konsole</span><span style="color: #aa2211">::</span><span class="n">ViewManager</span><span style="color: #aa2211">::</span><span class="n">lastUsedViewReverse</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you change this to be the shortcut from lastUsedViewAction + Shift?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18154">https://phabricator.kde.org/D18154</a></div></div><br /><div><strong>To: </strong>tcanabrava, hindenburg, Konsole<br /><strong>Cc: </strong>mglb, ngraham, thsurrel, lucasew, mart, konsole-devel, maciejn, maximilianocuria, hindenburg<br /></div>