D17643: Multiple Splits per Tab

[Kurt Hindenburg]

hindenburg added a comment.


  minor nitpicks

INLINE COMMENTS

> ViewManager.cpp:737
>  void ViewManager::containerViewsChanged(TabbedViewContainer *container)
>  {
> +    // TODO: Verify that this is right.

container not used

> ViewSplitter.cpp:154
> +        auto targetSplitter = qobject_cast<QSplitter*>(child->parent());
> +        auto terminal = qobject_cast<TerminalDisplay*>(targetSplitter->widget(0));
> +        terminal->setFocus(Qt::OtherFocusReason);

try not to shadow another variable here

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D17643

To: tcanabrava, #konsole
Cc: ngraham, thsurrel, maciejn, mglb, hindenburg, konsole-devel, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190125/6dfb577f/attachment.html>