D17643: Multiple Splits per Tab
noreply at phabricator.kde.org
Fri Jan 25 03:34:14 GMT 2019
hindenburg added a comment.
I'm still testing - I also notice it is hard to see the splitters - often I get another's view scrollbar confused w/ the splitter. I also notice some issues w/ how multiple splits hare calculated; I would think the other view would not change size.
If anyone could review the code, I'd appreciate more people looking now.
> + <Action name="detach-tab" />
> <Action name="detach-view"/>
When changing rc files, you have to increase the version at the top of file. Also, I'm not sure the 2 detach items should be under View - although I understand why you put them there.
> + RIGHT = Qt::Key_Right
Is this related to the splits?
> + * */
> + //
> // Add the read-only action
So the tab right click menu no longer has 'Read Only' - do you plan on fixing this before this is committed?
> - _viewSplitter->activateNextContainer();
> +// _viewSplitter->activateNextContainer();
> + //TODO: Handle sessions
> +#if 0
> auto *activeview = qobject_cast<TerminalDisplay *>(container->currentWidget());
I need to test session restores w/ splits.
To: tcanabrava, #konsole
Cc: ngraham, thsurrel, maciejn, mglb, hindenburg, konsole-devel, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the konsole-devel