D18352: Remember last output save directory

[Mariusz Glebocki]

mglb added a comment.


  In case of using file URL, I would change the variable name (like `_saveDialogFileURL` or something) and use `selectURL()` after creating the dialog object. The constructor, according to documentation, takes URL to the directory. It works OK now, but in theory can change in the future.
  When using `selectURL()`, home directory could be always used in the constructor, and the function would be called only if `_saveDialogFileURL` is not empty.

INLINE COMMENTS

> guotao wrote in SaveHistoryTask.cpp:82
> @mglb 
> I think there are 4 cases
> 
> 1. User want overwrite the last output file
> 2. User don't want overwrite the last output file, but only adjust the filename (eg: increase file counter number)
> 3. User want save output file to different name
> 4. User want save output file to different path
> 
> For 1,2  file is better
> For 3 directory is better, but file is ok too (we can change the filename immediately)
> For 4,file, directory or home dir are all not good
> 
> For me, I use case 2 most time during working.

Good idea. It asks for overwrite confirmation, the file name is already selected (so typing another name takes as much work as when there were no name). No downsides.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D18352

To: guotao, #konsole
Cc: ngraham, mglb, konsole-devel, thsurrel, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190119/83fd9d7a/attachment-0001.html>