D17244: Edit Profile Dialog UI redesign

Mariusz Glebocki noreply at phabricator.kde.org
Tue Feb 26 09:39:41 GMT 2019


mglb added inline comments.

INLINE COMMENTS

> hindenburg wrote in EditProfileDialog.cpp:222
> Can you explain why you expand the width here?  On small screens, this causes the dialog to be much bigger and the right side of the dialog goes off the desktop edge.  Removing this addition makes it appear as expected.

IIRC to make text inputs in "tab titles" a bit wider by default.
I got 553x585px with Noto Sans Display 8pt at 96dpi, and 902x742px with 15pt. Did you get something bigger, or those values are too big?

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D17244

To: mglb, #konsole, #vdg, ngraham, hindenburg
Cc: emateli, loh.tar, hein, mart, hindenburg, rizzitello, abetts, ngraham, konsole-devel, gennad, maciejn, thsurrel, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190226/d9c73bd8/attachment.html>


More information about the konsole-devel mailing list