D17244: Edit Profile Dialog UI redesign

[Kurt Hindenburg]

hindenburg added inline comments.

INLINE COMMENTS

> EditProfileDialog.cpp:222
> +    // Increase width a bit instead of using possible minimum
> +    resize(sizeHint().width() + 10*ch, sizeHint().height());
>  

Can you explain why you expand the width here?  On small screens, this causes the dialog to be much bigger and the right side of the dialog goes off the desktop edge.  Removing this addition makes it appear as expected.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D17244

To: mglb, #konsole, #vdg, ngraham, hindenburg
Cc: emateli, loh.tar, hein, mart, hindenburg, rizzitello, abetts, ngraham, konsole-devel, gennad, maciejn, thsurrel, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190226/b60ffbdc/attachment-0001.html>