c++14/17 - Fwd: Re: Konsole | Simplify filters (!59)

[kurt.hindenburg at gmail.com]

Does anyone have an opinion if we should require c++14 or c++17? 14 
seems reasonable but sure about 17.


Kurt



-------- Forwarded Message --------
Subject: 	Re: Konsole | Simplify filters (!59)
Date: 	Sun, 22 Dec 2019 21:09:26 +0000
From: 	Tomaz Canabrava <noreply at kde.org>
Reply-To: 	KDE / Konsole 
<incoming+b8f09169d0d79ff3690046dd88efdfda at invent.kde.org>
To: 	kurt.hindenburg at gmail.com



GitLab

Tomaz Canabrava <https://invent.kde.org/tcanabrava> commented on a 
discussion on src/Filter.cpp 
<https://invent.kde.org/kde/konsole/merge_requests/59#note_21242>:

360 	329 	

  QRegularExpressionMatchIterator iterator(_searchText.globalMatch(*text));

361 	330 	

  while (iterator.hasNext()) {

362 	331 	

  QRegularExpressionMatch match(iterator.next());

363 	
	

-

364 	
	

-int startLine = 0;

365 	
	

-int endLine = 0;

366 	
	

-int startColumn = 0;

367 	
	

-int endColumn = 0;

368 	
	

-

369 	
	

-getLineColumn(match.capturedStart(), startLine, startColumn);

370 	
	

-getLineColumn(match.capturedEnd(), endLine, endColumn);


	332 	

+auto [startLine, startColumn] = getLineColumn(match.capturedStart());


	333 	

+auto [endLine, endColumn] = getLineColumn(match.capturedEnd());

can we bump to c++14 or 17? it's been six years already since 14 :)

—
Reply to this email directly or view it on GitLab 
<https://invent.kde.org/kde/konsole/merge_requests/59#note_21242>.
You're receiving this email because of your account on invent.kde.org. 
If you'd like to receive fewer emails, you can unsubscribe 
<https://invent.kde.org/sent_notifications/b8f09169d0d79ff3690046dd88efdfda/unsubscribe> 
from this thread or adjust your notification settings.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20191226/e034a522/attachment-0001.html>