<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Does anyone have an opinion if we should require c++14 or c++17?
14 seems reasonable but sure about 17.<br>
</p>
<p><br>
</p>
<p>Kurt<br>
</p>
<div class="moz-forward-container"><br>
<br>
-------- Forwarded Message --------
<table class="moz-email-headers-table" cellspacing="0"
cellpadding="0" border="0">
<tbody>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">Subject:
</th>
<td>Re: Konsole | Simplify filters (!59)</td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">Date: </th>
<td>Sun, 22 Dec 2019 21:09:26 +0000</td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">From: </th>
<td>Tomaz Canabrava <a class="moz-txt-link-rfc2396E" href="mailto:noreply@kde.org"><noreply@kde.org></a></td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">Reply-To:
</th>
<td>KDE / Konsole
<a class="moz-txt-link-rfc2396E" href="mailto:incoming+b8f09169d0d79ff3690046dd88efdfda@invent.kde.org"><incoming+b8f09169d0d79ff3690046dd88efdfda@invent.kde.org></a></td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">To: </th>
<td><a class="moz-txt-link-abbreviated" href="mailto:kurt.hindenburg@gmail.com">kurt.hindenburg@gmail.com</a></td>
</tr>
</tbody>
</table>
<br>
<br>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
<div class="content">
<p style="color: #777777;">
<a href="https://invent.kde.org/tcanabrava"
moz-do-not-send="true">Tomaz Canabrava</a>
commented on a
discussion on <a
href="https://invent.kde.org/kde/konsole/merge_requests/59#note_21242"
moz-do-not-send="true">src/Filter.cpp</a>:
</p>
<table>
<tbody>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="360"
style="width: 35px; color: rgba(0,0,0,0.3);
border-right-width: 1px; border-right-color: #f0f0f0;
border-right-style: solid; padding: 0 5px;"
bgcolor="#fafafa" align="right">
360
</td>
<td class="diff-line-num new_line" data-linenumber="329"
style="width: 35px; color: rgba(0,0,0,0.3);
border-right-width: 1px; border-right-color: #f0f0f0;
border-right-style: solid; padding: 0 5px;"
bgcolor="#fafafa" align="right">
329
</td>
<td class="line_content" style="padding-left: 0.5em;
padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC329" class="line" lang="cpp"> <span class="n" style="color: #333;">QRegularExpressionMatchIterator</span> <span class="n" style="color: #333;">iterator</span><span class="p">(</span><span class="n" style="color: #333;">_searchText</span><span class="p">.</span><span class="n" style="color: #333;">globalMatch</span><span class="p">(</span><span class="o" style="font-weight: 600;">*</span><span class="n" style="color: #333;">text</span><span class="p">));</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="361"
style="width: 35px; color: rgba(0,0,0,0.3);
border-right-width: 1px; border-right-color: #f0f0f0;
border-right-style: solid; padding: 0 5px;"
bgcolor="#fafafa" align="right">
361
</td>
<td class="diff-line-num new_line" data-linenumber="330"
style="width: 35px; color: rgba(0,0,0,0.3);
border-right-width: 1px; border-right-color: #f0f0f0;
border-right-style: solid; padding: 0 5px;"
bgcolor="#fafafa" align="right">
330
</td>
<td class="line_content" style="padding-left: 0.5em;
padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC330" class="line" lang="cpp"> <span class="k" style="font-weight: 600;">while</span> <span class="p">(</span><span class="n" style="color: #333;">iterator</span><span class="p">.</span><span class="n" style="color: #333;">hasNext</span><span class="p">())</span> <span class="p">{</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="362"
style="width: 35px; color: rgba(0,0,0,0.3);
border-right-width: 1px; border-right-color: #f0f0f0;
border-right-style: solid; padding: 0 5px;"
bgcolor="#fafafa" align="right">
362
</td>
<td class="diff-line-num new_line" data-linenumber="331"
style="width: 35px; color: rgba(0,0,0,0.3);
border-right-width: 1px; border-right-color: #f0f0f0;
border-right-style: solid; padding: 0 5px;"
bgcolor="#fafafa" align="right">
331
</td>
<td class="line_content" style="padding-left: 0.5em;
padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC331" class="line" lang="cpp"> <span class="n" style="color: #333;">QRegularExpressionMatch</span> <span class="n" style="color: #333;">match</span><span class="p">(</span><span class="n" style="color: #333;">iterator</span><span class="p">.</span><span class="n" style="color: #333;">next</span><span class="p">());</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line"
data-linenumber="363" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right">
363
</td>
<td class="diff-line-num new_line old"
data-linenumber="332" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td class="line_content old" style="padding-left: 0.5em;
padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC363" class="line" lang="cpp"></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line"
data-linenumber="364" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right">
364
</td>
<td class="diff-line-num new_line old"
data-linenumber="332" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td class="line_content old" style="padding-left: 0.5em;
padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC364" class="line" lang="cpp"> <span class="kt" style="color: #458; font-weight: 600;">int</span> <span class="n" style="color: #333;">startLine</span> <span class="o" style="font-weight: 600;">=</span> <span class="mi" style="color: #099;">0</span><span class="p">;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line"
data-linenumber="365" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right">
365
</td>
<td class="diff-line-num new_line old"
data-linenumber="332" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td class="line_content old" style="padding-left: 0.5em;
padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC365" class="line" lang="cpp"> <span class="kt" style="color: #458; font-weight: 600;">int</span> <span class="n" style="color: #333;">endLine</span> <span class="o" style="font-weight: 600;">=</span> <span class="mi" style="color: #099;">0</span><span class="p">;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line"
data-linenumber="366" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right">
366
</td>
<td class="diff-line-num new_line old"
data-linenumber="332" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td class="line_content old" style="padding-left: 0.5em;
padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC366" class="line" lang="cpp"> <span class="kt" style="color: #458; font-weight: 600;">int</span> <span class="n" style="color: #333;">startColumn</span> <span class="o" style="font-weight: 600;">=</span> <span class="mi" style="color: #099;">0</span><span class="p">;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line"
data-linenumber="367" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right">
367
</td>
<td class="diff-line-num new_line old"
data-linenumber="332" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td class="line_content old" style="padding-left: 0.5em;
padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC367" class="line" lang="cpp"> <span class="kt" style="color: #458; font-weight: 600;">int</span> <span class="n" style="color: #333;">endColumn</span> <span class="o" style="font-weight: 600;">=</span> <span class="mi" style="color: #099;">0</span><span class="p">;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line"
data-linenumber="368" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right">
368
</td>
<td class="diff-line-num new_line old"
data-linenumber="332" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td class="line_content old" style="padding-left: 0.5em;
padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC368" class="line" lang="cpp"></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line"
data-linenumber="369" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right">
369
</td>
<td class="diff-line-num new_line old"
data-linenumber="332" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td class="line_content old" style="padding-left: 0.5em;
padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC369" class="line" lang="cpp"> <span class="n" style="color: #333;">getLineColumn</span><span class="p">(</span><span class="n" style="color: #333;">match</span><span class="p">.</span><span class="n" style="color: #333;">capturedStart</span><span class="p">(),</span> <span class="n" style="color: #333;">startLine</span><span class="p">,</span> <span class="n" style="color: #333;">startColumn</span><span class="p">);</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line"
data-linenumber="370" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right">
370
</td>
<td class="diff-line-num new_line old"
data-linenumber="332" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #fac5cd; border-right-style: solid;
padding: 0 5px;" bgcolor="#f9d7dc" align="right"> <br>
</td>
<td class="line_content old" style="padding-left: 0.5em;
padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC370" class="line" lang="cpp"> <span class="n" style="color: #333;">getLineColumn</span><span class="p">(</span><span class="n" style="color: #333;">match</span><span class="p">.</span><span class="n" style="color: #333;">capturedEnd</span><span class="p">(),</span> <span class="n" style="color: #333;">endLine</span><span class="p">,</span> <span class="n" style="color: #333;">endColumn</span><span class="p">);</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line"
data-linenumber="371" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #c7f0d2; border-right-style: solid;
padding: 0 5px;" bgcolor="#ddfbe6" align="right"> <br>
</td>
<td class="diff-line-num new new_line"
data-linenumber="332" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #c7f0d2; border-right-style: solid;
padding: 0 5px;" bgcolor="#ddfbe6" align="right">
332
</td>
<td class="line_content new" style="padding-left: 0.5em;
padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC332" class="line" lang="cpp"> <span class="k" style="font-weight: 600;">auto</span> <span class="p">[</span><span class="n" style="color: #333;">startLine</span><span class="p">,</span> <span class="n" style="color: #333;">startColumn</span><span class="p">]</span> <span class="o" style="font-weight: 600;">=</span> <span class="n" style="color: #333;">getLineColumn</span><span class="p">(</span><span class="n" style="color: #333;">match</span><span class="p">.</span><span class="n" style="color: #333;">capturedStart</span><span class="p">());</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line"
data-linenumber="371" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #c7f0d2; border-right-style: solid;
padding: 0 5px;" bgcolor="#ddfbe6" align="right"> <br>
</td>
<td class="diff-line-num new new_line"
data-linenumber="333" style="width: 35px; color:
rgba(0,0,0,0.3); border-right-width: 1px;
border-right-color: #c7f0d2; border-right-style: solid;
padding: 0 5px;" bgcolor="#ddfbe6" align="right">
333
</td>
<td class="line_content new" style="padding-left: 0.5em;
padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC333" class="line" lang="cpp"> <span class="k" style="font-weight: 600;">auto</span> <span class="p">[</span><span class="n" style="color: #333;">endLine</span><span class="p">,</span> <span class="n" style="color: #333;">endColumn</span><span class="p">]</span> <span class="o" style="font-weight: 600;">=</span> <span class="n" style="color: #333;">getLineColumn</span><span class="p">(</span><span class="n" style="color: #333;">match</span><span class="p">.</span><span class="n" style="color: #333;">capturedEnd</span><span class="p">());</span></span>
</pre>
</td>
</tr>
</tbody>
</table>
<div style="">
<p dir="auto">can we bump to c++14 or 17? it's been six years
already since 14 :)</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a
href="https://invent.kde.org/kde/konsole/merge_requests/59#note_21242"
moz-do-not-send="true">view it on GitLab</a>.
<br>
You're receiving this email because of your account on
invent.kde.org.
If you'd like to receive fewer emails, you can
<a
href="https://invent.kde.org/sent_notifications/b8f09169d0d79ff3690046dd88efdfda/unsubscribe"
moz-do-not-send="true">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://invent.kde.org/kde/konsole/merge_requests/59#note_21242"}}</script>
</p>
</div>
</div>
</body>
</html>