D20438: Small code simplifications

Ahmed Bilal noreply at phabricator.kde.org
Wed Apr 10 19:12:13 BST 2019


ahmedbilal added inline comments.

INLINE COMMENTS

> ngraham wrote in BookmarkHandler.cpp:105
> Why not an empty `QUrl()`?

The author is trying to use return {} feature in C++ 11 <https://stackoverflow.com/questions/39487065/what-does-return-statement-mean-in-c11>. However, QUrl() is more explicit for those who does or doesn't know about the previously mentioned feature.

Explicit is better then Implicit.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D20438

To: tcanabrava, #konsole, hindenburg
Cc: ahmedbilal, gennad, ngraham, konsole-devel, thsurrel, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190410/4e987c45/attachment.html>


More information about the konsole-devel mailing list