D20438: Small code simplifications

[Tomaz Canabrava]

tcanabrava added a subscriber: gennad.
tcanabrava added a comment.


  {}; means “default value of the return type”, so I’m retirning a QUrl()
  where it’s supposed to be a QUrl, and a QString where it’s supposed to be a
  string.
  
  This is more future proof as if we change the type of the function we don’t
  need to change that return.
  
  Em qua, 10 de abr de 2019 às 19:21, Nathaniel Graham <
  noreply at phabricator.kde.org> escreveu:
  
  > ngraham added inline comments. View Revision
  >  https://phabricator.kde.org/D20438
  >  *INLINE COMMENTS*
  >  View Inline https://phabricator.kde.org/D20438#inline-114927
  >  BookmarkHandler.cpp:105
  >  }
  >  return {};
  >  }
  > 
  > Why not an empty QUrl()?
  > 
  > View Inline https://phabricator.kde.org/D20438#inline-114928
  >  BookmarkHandler.cpp:145
  >  }
  >  return {};
  >  }
  > 
  > Why not an empty QString()?
  > 
  > *REPOSITORY*
  >  R319 <https://phabricator.kde.org/source/konsole/> Konsole
  > 
  > *REVISION DETAIL*
  >  https://phabricator.kde.org/D20438
  > 
  > *To: *tcanabrava, Konsole, hindenburg
  >  *Cc: *ngraham, konsole-devel, gennad, thsurrel, maximilianocuria,
  > hindenburg

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D20438

To: tcanabrava, #konsole, hindenburg
Cc: gennad, ngraham, konsole-devel, thsurrel, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190410/6143d3a1/attachment.html>