D14200: Simplify newSession code

Tomaz Canabrava noreply at phabricator.kde.org
Wed Apr 10 15:29:56 BST 2019


tcanabrava added a comment.


  We set this variable in two or three different files and in a few different
  methods. I remember that one of the first things that I tried to do for
  konsole was to simplify the creation of sessions (and this broke a lot of
  code and you where not happy) but it seems that we do need to make some
  compromise and align that.
  
  Em qua, 10 de abr de 2019 às 16:27, Kurt Hindenburg <
  noreply at phabricator.kde.org> escreveu:
  
  > hindenburg added a comment. View Revision
  >  https://phabricator.kde.org/D14200
  > 
  > In D14200#447412 <https://phabricator.kde.org/D14200#447412> https://phabricator.kde.org/D14200#447412, @hindenburg
  >  https://phabricator.kde.org/p/hindenburg/ wrote:
  > 
  > and it looks like $KONSOLE_DBUS_WINDOW is not set in 19.04.0
  > 
  > Well sometimes it is set and sometimes not
  > 
  > *REPOSITORY*
  >  R319 <https://phabricator.kde.org/source/konsole/> Konsole
  > 
  > *REVISION DETAIL*
  >  https://phabricator.kde.org/D14200
  > 
  > *To: *tcanabrava, Konsole, hindenburg
  >  *Cc: *thsurrel, gennad, konsole-devel, ngraham, maximilianocuria,
  > hindenburg

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D14200

To: tcanabrava, #konsole, hindenburg
Cc: thsurrel, gennad, konsole-devel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190410/b77371f1/attachment-0001.html>


More information about the konsole-devel mailing list