D20224: Implement saving sessions recursively

Tomaz Canabrava noreply at phabricator.kde.org
Tue Apr 9 10:03:05 BST 2019

tcanabrava added inline comments.


> hindenburg wrote in ViewManager.cpp:910
> FYI, loop variable 'widgetJsonValue' is always a copy because the range of type 'QJsonArray' does not return a reference

Having the reference of a temporary is not a problem, and considering the clazy warning on your other comment I belive this is the way to go.

> hindenburg wrote in ViewManager.cpp:931
> Missing reference in range-for with non trivial type (QJsonValue) [-Wclazy-range-loop

That's a QJsonArray too. I'll just add the reference to the temporary.

  R319 Konsole


To: tcanabrava, #konsole, hindenburg, ngraham
Cc: konsole-devel, gennad, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190409/e7da75aa/attachment.html>

More information about the konsole-devel mailing list