D20224: Implement saving sessions recursively

[Kurt Hindenburg]

hindenburg added a comment.


  A couple of clazy warning if you want to look at

INLINE COMMENTS

> ViewManager.cpp:910
>  
> -        if (session == nullptr) {
> -            qWarning() << "Unable to load session with id" << id;
> -            // Force a creation of a default session below
> -            ids.clear();
> -            break;
> -        }
> +    for (const auto& widgetJsonValue : splitterWidgets) {
> +        const auto widgetJsonObject = widgetJsonValue.toObject();

FYI, loop variable 'widgetJsonValue' is always a copy because the range of type 'QJsonArray' does not return a reference

> ViewManager.cpp:931
> +    const auto jsonTabs = QJsonDocument::fromJson(tabList).array();
> +    for (const auto jsonSplitter : jsonTabs) {
> +        auto topLevelSplitter = restoreSessionsSplitterRecurse(jsonSplitter.toObject(), this);

Missing reference in range-for with non trivial type (QJsonValue) [-Wclazy-range-loop

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D20224

To: tcanabrava, #konsole, hindenburg, ngraham
Cc: konsole-devel, gennad, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190409/fbc41c62/attachment-0001.html>