D15756: Move character width functions to Character class

Mariusz Glebocki noreply at phabricator.kde.org
Wed Sep 26 01:52:58 BST 2018


mglb created this revision.
mglb added a reviewer: Konsole.
mglb added a project: Konsole.
mglb requested review of this revision.

REVISION SUMMARY
  Replaces direct konsole_wcwidth() calls with Character object property
  and the class static function, which internally still use
  konsole_wcwidth().
  
  The change also prepares the codebase for a new code for determining
  character width. This way the change will barely touch existing code.
  
  CCBUG: 396435

TEST PLAN
  konsole_wcwidth() is still used, just in one central place. Passed
  compilation and CharacterWidthTest should be enough.

REPOSITORY
  R319 Konsole

BRANCH
  arc/396435/Move-character-width-functions-to-Character-class (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15756

AFFECTED FILES
  src/Character.h
  src/Filter.cpp
  src/Screen.cpp
  src/TerminalCharacterDecoder.cpp
  src/TerminalDisplay.cpp
  src/autotests/CharacterWidthTest.cpp

To: mglb, #konsole
Cc: konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180926/1a9f26dd/attachment.html>


More information about the konsole-devel mailing list