<table><tr><td style="">mglb created this revision.<br />mglb added a reviewer: Konsole.<br />mglb added a project: Konsole.<br />mglb requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15756">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Replaces direct konsole_wcwidth() calls with Character object property<br />
and the class static function, which internally still use<br />
konsole_wcwidth().</p>
<p>The change also prepares the codebase for a new code for determining<br />
character width. This way the change will barely touch existing code.</p>
<p>CCBUG: 396435</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>konsole_wcwidth() is still used, just in one central place. Passed<br />
compilation and CharacterWidthTest should be enough.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>BRANCH</strong><div><div>arc/396435/Move-character-width-functions-to-Character-class (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15756">https://phabricator.kde.org/D15756</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/Character.h<br />
src/Filter.cpp<br />
src/Screen.cpp<br />
src/TerminalCharacterDecoder.cpp<br />
src/TerminalDisplay.cpp<br />
src/autotests/CharacterWidthTest.cpp</div></div></div><br /><div><strong>To: </strong>mglb, Konsole<br /><strong>Cc: </strong>konsole-devel, herrold, ngraham, maximilianocuria, hindenburg<br /></div>