D15570: Use new connection style

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> MainWindow.cpp:348
>      // Settings Menu
> -    _toggleMenuBarAction = KStandardAction::showMenubar(menuBar(), SLOT(setVisible(bool)), collection);
> +    _toggleMenuBarAction = KStandardAction::showMenubar(menuBar(), &MainWindow::setVisible, collection);
>      collection->setDefaultShortcut(_toggleMenuBarAction, Konsole::ACCEL + Qt::SHIFT + Qt::Key_M);

It should be setVisible on QMenuBar not on MainWindow

  toggleMenuBarAction = KStandardAction::showMenubar(menuBar(), &QMenuBar::setVisible, collection);

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D15570

To: tcanabrava
Cc: anthonyfieroni, konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180917/bcf9b619/attachment.html>