<table><tr><td style="">anthonyfieroni added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15570">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15570#inline-83869">View Inline</a><span style="color: #4b4d51; font-weight: bold;">MainWindow.cpp:348</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// Settings Menu</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">_toggleMenuBarAction</span> <span style="color: #aa2211">=</span> <span class="n">KStandardAction</span><span style="color: #aa2211">::</span><span class="n">showMenubar</span><span class="p">(</span><span class="n">menuBar</span><span class="p">(),</span> <span class="bright"></span><span class="n"><span class="bright">SLOT</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">setVisible<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"></span><span class="p"><span class="bright">))</span>,</span> <span class="n">collection</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">_toggleMenuBarAction</span> <span style="color: #aa2211">=</span> <span class="n">KStandardAction</span><span style="color: #aa2211">::</span><span class="n">showMenubar</span><span class="p">(</span><span class="n">menuBar</span><span class="p">(),</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"></span><span class="n"><span class="bright">MainWindow</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="n">setVisible</span><span class="p">,</span> <span class="n">collection</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">collection</span><span style="color: #aa2211">-></span><span class="n">setDefaultShortcut</span><span class="p">(</span><span class="n">_toggleMenuBarAction</span><span class="p">,</span> <span class="n">Konsole</span><span style="color: #aa2211">::</span><span class="n">ACCEL</span> <span style="color: #aa2211">+</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">SHIFT</span> <span style="color: #aa2211">+</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">Key_M</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It should be setVisible on QMenuBar not on MainWindow</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">toggleMenuBarAction = KStandardAction::showMenubar(menuBar(), &QMenuBar::setVisible, collection);</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15570">https://phabricator.kde.org/D15570</a></div></div><br /><div><strong>To: </strong>tcanabrava<br /><strong>Cc: </strong>anthonyfieroni, konsole-devel, herrold, ngraham, maximilianocuria, hindenburg<br /></div>