D15295: [konsole]: proper fix for a crash-on-exit
René J.V. Bertin
noreply at phabricator.kde.org
Wed Sep 5 16:07:31 BST 2018
rjvbb added a comment.
> I say that because in one of my konsole branches I removed that and it indeed worked.
"it worked" to prevent crashing on exit? If so your approach would be an alternative fix.
But it really depends on whether or not containers are deleted immediately after the last tab is closed and/or on whether they need to remain registered until the last moment. That's something that the people working on tab/window management can say (they should also have an idea how this might evolve).
As long as I'm not 100% certain of this aspect of the design I prefer to consider merging the functions as a separate change.
REPOSITORY
R319 Konsole
REVISION DETAIL
https://phabricator.kde.org/D15295
To: rjvbb, #konsole, gateau, hindenburg
Cc: tcanabrava, konsole-devel, #kde_applications, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180905/80eb03d9/attachment.html>
More information about the konsole-devel
mailing list