D13217: Move isPrimaryScreen() to the Session class

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added a reviewer: Konsole.
Restricted Application added a project: Konsole.
Restricted Application added a subscriber: konsole-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Previously the code enabled sending emulated up/down key press events to
  the terminal only if the current screen is the alternate buffer. The
  problem with this approach is that when detaching a tab/view, a new
  TerminalDisplay is constructed and _isPrimaryScreen is intialised to
  true even though the current screen in the detached tab is the alternate
  one.
  
  Since the Session is preserved when detaching a tab, move that bit of
  code to Session, and change the condition in TerminalDisplay
  accrodingly. Less/redundant code in TerminalDisplay and one less
  connection.

REPOSITORY
  R319 Konsole

BRANCH
  alternate-buffer-scrolling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13217

AFFECTED FILES
  src/Session.cpp
  src/Session.h
  src/SessionController.cpp
  src/TerminalDisplay.cpp
  src/TerminalDisplay.h

To: ahmadsamir, #konsole
Cc: konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180530/036a55ad/attachment-0001.html>