D13091: Small changes on the ViewManager related to simplification of the codebase

[Tomaz Canabrava]

tcanabrava abandoned this revision.
tcanabrava added a comment.


  In D13091#267841 <https://phabricator.kde.org/D13091#267841>, @hindenburg wrote:
  
  > It is better to create patches that deal with one aspect, not file based.   This allows for easier testing, review, git bisecting and reverting if necessary. This patch could be separated into 2 ones: the container patch and the view-> ones.  Also we try to put whitepaces changes in a separate patch.
  
  
  Ok, Will do that. Closing this one, tomorrow I'll upload a new set with those commits separated.

INLINE COMMENTS

> hindenburg wrote in ViewManager.cpp:113
> While I agree the current code is ugly, I'm not fond of these ternary operator

if well used (and by that I mean just when we are returning a variable without much logic on them) they are quite readable.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13091

To: tcanabrava, #konsole
Cc: hindenburg, konsole-devel, herrold, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180524/f5ec2b5d/attachment.html>