D13078: Ignore control characters in the text part of Xpe "ESC]" sequences

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added a reviewer: Konsole.
Restricted Application added a project: Konsole.
Restricted Application added a subscriber: konsole-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Ignore control characters in the text part of Xpe (OSC, Operating System
  Control) of the form "ESC]Pn;Pt\a" escape sequences; this matches what
  XTerm docs say.
  
  If userTitle is an empty string, set the window title to a blank space
  when showWindowTitleOnTitleBar is enabled; basically if the user sets
  the title to an empty string, leave it as-is.
  
  BUG: 315581
  FIXED-IN: 18.08

TEST PLAN
  - unset PROMPT_COMMAND, in case the shell is configured to set the window title via that variable
  - Make sure "Show window title on the title bar" is enabled
  - Execute:
  
  $ /usr/bin/echo -e 'j\e]2;\n\aj'
  
  - The window title is changed to the tab title text; and the output looks like this:
  
  j
  j
  
  - Apply the diff, build, and try again, the window title should be set to an empty string (really a blank space), and the output should look like:
  
  jj

REPOSITORY
  R319 Konsole

BRANCH
  osc-control-characters

REVISION DETAIL
  https://phabricator.kde.org/D13078

AFFECTED FILES
  src/MainWindow.cpp
  src/Vt102Emulation.cpp

To: ahmadsamir, #konsole
Cc: konsole-devel, #konsole, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180523/d90ca93a/attachment.html>