<table><tr><td style="">ahmadsamir created this revision.<br />ahmadsamir added a reviewer: Konsole.<br />Restricted Application added a project: Konsole.<br />Restricted Application added a subscriber: konsole-devel.<br />ahmadsamir requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13078">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Ignore control characters in the text part of Xpe (OSC, Operating System<br />
Control) of the form "ESC]Pn;Pt\a" escape sequences; this matches what<br />
XTerm docs say.</p>
<p>If userTitle is an empty string, set the window title to a blank space<br />
when showWindowTitleOnTitleBar is enabled; basically if the user sets<br />
the title to an empty string, leave it as-is.</p>
<p>BUG: 315581<br />
FIXED-IN: 18.08</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">unset PROMPT_COMMAND, in case the shell is configured to set the window title via that variable</li>
<li class="remarkup-list-item">Make sure "Show window title on the title bar" is enabled</li>
<li class="remarkup-list-item">Execute:</li>
</ul>
<p>$ /usr/bin/echo -e 'j\e]2;\n\aj'</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">The window title is changed to the tab title text; and the output looks like this:</li>
</ul>
<p>j<br />
j</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Apply the diff, build, and try again, the window title should be set to an empty string (really a blank space), and the output should look like:</li>
</ul>
<p>jj</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>BRANCH</strong><div><div>osc-control-characters</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13078">https://phabricator.kde.org/D13078</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/MainWindow.cpp<br />
src/Vt102Emulation.cpp</div></div></div><br /><div><strong>To: </strong>ahmadsamir, Konsole<br /><strong>Cc: </strong>konsole-devel, Konsole, herrold, ngraham, maximilianocuria, hindenburg<br /></div>