D12967: Remove unecessary forward-calls

Tomaz Canabrava noreply at phabricator.kde.org
Wed May 23 07:29:10 UTC 2018


tcanabrava added inline comments.

INLINE COMMENTS

> pedroarthurp wrote in Application.cpp:433
> I can see that in `MainWindow.h` and `MainWindow.cpp` this pattern is doing more harm than good. However, it seems to make sense from client-code perspective. Hence, in these two specific cases (this line and line 437), you could create methods such as `showTabBar` and `hideTabBar`.

That's not really possible currently as the tabbar is unrelated to the window, what to do in the case of two tabbars, etc.
in a following patch I plan to ditch the tabbar management code and replace with something more sane.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D12967

To: tcanabrava, #konsole
Cc: pedroarthurp, konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180523/5ea91264/attachment-0001.html>


More information about the konsole-devel mailing list