D12967: Remove unecessary forward-calls

[Pedro Arthur P. R. Duarte]

pedroarthurp added inline comments.

INLINE COMMENTS

> Application.cpp:433
>              // always show
> -            window->setNavigationVisibility(0);
> +            window->viewManager()->setNavigationVisibility(0);
>          }

I can see that in `MainWindow.h` and `MainWindow.cpp` this pattern is doing more harm than good. However, it seems to make sense from client-code perspective. Hence, in these two specific cases (this line and line 437), you could create methods such as `showTabBar` and `hideTabBar`.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D12967

To: tcanabrava, #konsole
Cc: pedroarthurp, konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180521/5ac44f92/attachment.html>