D12964: Remove StackView

[Tomaz Canabrava]

tcanabrava added inline comments.

INLINE COMMENTS

> pedroarthurp wrote in ViewManager.cpp:705
> I would take this to a method:
> 
>   if (tabbedNavigation()) {
>       container->setTabBarVisible(true);
>   }
> 
> or
> 
>   container->setTabBarVisible(tabbedNavigation());
> 
> If it is clear enough.

I can't set it to "container->setTabBarVisible(tabbedNavigation());" as it would show the tabbar even when there's only one view, and that's not what konsole expects. also, I don't think a new method that only does a single boolean operation is really needed. :)

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D12964

To: tcanabrava, #konsole
Cc: pedroarthurp, konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180523/a4c5c2cc/attachment.html>