D12964: Remove StackView

[Pedro Arthur P. R. Duarte]

pedroarthurp added inline comments.

INLINE COMMENTS

> ViewManager.cpp:705
>  
> +    if (_navigationMethod != TabbedNavigation) {
> +        container->setTabBarVisible(false);

I would take this to a method:

  if (tabbedNavigation()) {
      container->setTabBarVisible(true);
  }

or

  container->setTabBarVisible(tabbedNavigation());

If it is clear enough.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D12964

To: tcanabrava, #konsole
Cc: pedroarthurp, konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180521/d9510968/attachment.html>