D11241: TerminalDisplay: Use default close button of KMessageWidget

Joshua Noack noreply at phabricator.kde.org
Sun Mar 11 18:22:30 UTC 2018


jnoack created this revision.
jnoack added a reviewer: ach.
Restricted Application added a subscriber: Konsole.
Restricted Application added a project: Konsole.
jnoack requested review of this revision.

REVISION SUMMARY
  D10935 <https://phabricator.kde.org/D10935> introduced KMessageWidgets in TerminalDisplay. This patch restores the 
  default close button and makes use of animateShow/animateHide. A nice plus is 
  that I also removed some code which has become obsolete AND that the 
  messages are now animated.

TEST PLAN
  Show/hide works like before.
  Also still works if readonly and suspended at the same time.
  Detaching works.

REPOSITORY
  R319 Konsole

BRANCH
  use-default-messagewidget-close-action

REVISION DETAIL
  https://phabricator.kde.org/D11241

AFFECTED FILES
  src/TerminalDisplay.cpp
  src/TerminalDisplay.h

To: jnoack, ach
Cc: ach, #konsole, herrold, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180311/f4dcbe88/attachment.html>


More information about the konsole-devel mailing list